[MASSEMBLY-961] Update maven-archiver to 3.6.0 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
changed the title
| public class DebugConfigurationListener | ||
| implements ConfigurationListener | ||
| { | ||
| private final Logger logger; |
There was a problem hiding this comment.
Maybe logger can be initialized here instead of pass as argument.
There was a problem hiding this comment.
Yes, but I would rather throw this class out in next major. The benefit is very little.
michael-o
approved these changes
Jun 28, 2022
| public class DebugConfigurationListener | ||
| implements ConfigurationListener | ||
| { | ||
| private final Logger logger; |
There was a problem hiding this comment.
Yes, but I would rather throw this class out in next major. The benefit is very little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade:
These are now pure JSR330 components, and legacy APIs are dropped, so drop whatever cruft needed from assembly plugin as well.
https://issues.apache.org/jira/browse/MASSEMBLY-961